feat: demonstrate contract-first CRDs #1524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify the leader-election sample to use contract-first. That is, the CRDs is written in YAML and the java code is generated automatically using the java-generator-maven-plugin from fabric8.
Lots of silly mistakes, sorry for that.
|
I missed lots of details, sorry for that. Should be fixed now ! |
metacosm
reviewed
Oct 7, 2022
| @@ -0,0 +1,34 @@ | |||
| # Custom Resource Definition that will be used to generate the Java classes in target/generated-sources/java | |||
There was a problem hiding this comment.
While this probably isn't a big deal, I think that if we try to follow the CRD generator file name format here, then this file should be named with leaderelections (plural form) instead of leaderelection (singular).
|
@metacosm Great thanks! May I kindly ask to add the label hacktoberfest-accepted to it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the leader-election sample to use contract-first. That is, the CRDs is written in YAML and the java code is generated automatically using the java-generator-maven-plugin from fabric8.
#1338